----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59753/#review176898 -----------------------------------------------------------
Ship it! fix the minor error and ship it - Ramesh Mani On June 2, 2017, 4:46 p.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59753/ > ----------------------------------------------------------- > > (Updated June 2, 2017, 4:46 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1630 > https://issues.apache.org/jira/browse/RANGER-1630 > > > Repository: ranger > > > Description > ------- > > The StormClient doesn't decrypt the password. That means if you create a > service, save it, and go back and edit it and test the connection, it will > fail. I also did some refactoring to move the local class out to a private > static class instead. > > > Diffs > ----- > > > storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java > b72a9a23 > > > Diff: https://reviews.apache.org/r/59753/diff/1/ > > > Testing > ------- > > Tested we can connect successfully to Storm. > > > Thanks, > > Colm O hEigeartaigh > >
