----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59999/#review177663 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On June 12, 2017, 12:48 p.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59999/ > ----------------------------------------------------------- > > (Updated June 12, 2017, 12:48 p.m.) > > > Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, > Mehul Parikh, and Velmurugan Periasamy. > > > Bugs: RANGER-1492 > https://issues.apache.org/jira/browse/RANGER-1492 > > > Repository: ranger > > > Description > ------- > > UI should be updated to support tag-based masking policies, in addition to > existing tag-based access policies. Similar to Hive services, UI can show > 'Masking' tab for tag-services when tag serviceDef has non-empty dataMaskDef. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js > 1aace56 > security-admin/src/main/webapp/scripts/modules/XAOverrides.js 311ad0c > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > f47276c > security-admin/src/main/webapp/scripts/utils/XAUtils.js 03e218d > security-admin/src/main/webapp/scripts/views/policies/PermissionList.js > 2bb4d8a > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js > 728e5bf > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js > ff62bb2 > > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js > 1eaf3da > security-admin/src/main/webapp/styles/xa.css c70c0bc > security-admin/src/main/webapp/templates/helpers/XAHelpers.js 4491d70 > security-admin/src/main/webapp/templates/policies/PermissionItem.html > 745c881 > > security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html > 865ea72 > > security-admin/src/main/webapp/templates/policies/RangerPolicyTableLayout_tmpl.html > 5031c7f > > > Diff: https://reviews.apache.org/r/59999/diff/1/ > > > Testing > ------- > > 1. Verified CRUD for tag-based masking policy. > 2. Verified Admin logs under Audit tab for all the operations performed for > tag-based masking policy. > 3. Verified search filter for tag-based masking policy on Report Page and > Policy Listing Page. > 4. Able to see Access and Maksing tabs under tag policies listing page. > > > Thanks, > > Nitin Galave > >
