----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60192/#review178207 -----------------------------------------------------------
A few trivial code comments: a) String xForwardedPorto -> Should be "xForwardedProto" b) The "while" loop looks a bit odd...it will always discard all but the last value? c) loginURL = loginURL + -> Should just be loginURL += ... - Colm O hEigeartaigh On June 19, 2017, 8:58 a.m., Ankita Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60192/ > ----------------------------------------------------------- > > (Updated June 19, 2017, 8:58 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1653 > https://issues.apache.org/jira/browse/RANGER-1653 > > > Repository: ranger > > > Description > ------- > > **Actual** : > Ranger is not able to handle forwardable headers when proxying the Ranger UI > and turning on SSO for Ranger. > > **Expected** : > Proxying Ranger UI should work with Ranger-KnoxSSO > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java > b4f0ca8 > > > Diff: https://reviews.apache.org/r/60192/diff/1/ > > > Testing > ------- > > 1. Proxying Ranger UI works proper with Ranger SSO enabled > 2. Proxying Ranger UI works proper with Ranger SSO disabled > 3. Ranger working fine with SSO enable (without proxy) > 4. Ranger working fine without SSO and Proxy > > > Thanks, > > Ankita Sinha > >
