----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60193/#review178209 -----------------------------------------------------------
Ship it! Ship It! - Colm O hEigeartaigh On June 19, 2017, 9:10 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60193/ > ----------------------------------------------------------- > > (Updated June 19, 2017, 9:10 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1652 > https://issues.apache.org/jira/browse/RANGER-1652 > > > Repository: ranger > > > Description > ------- > > Some code lines are invalid in kms installer. > Like java, the assignment clause of some variables which are not used should > be deleted to inscrease execution efficienty and improve code clarity. > Invalid codes should be deleted to improve code clarity. > > > Diffs > ----- > > kms/scripts/setup.sh 297fdd2 > > > Diff: https://reviews.apache.org/r/60193/diff/1/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >
