> On 六月 21, 2017, 9:38 a.m., Colm O hEigeartaigh wrote: > > With the patch, the $LOGFILES property is not actually used at all. Do we > > know what $LOGFILES is meant to do, and why we have both $LOGFILE and > > $LOGFILES? > > pengjianhua wrote: > I also noticed your question. $LOGFILES should not be needed in current > context. I have been thinking, why the orignal developer added it? Do I > think we should remove it, your opinion? > > Colm O hEigeartaigh wrote: > I'm not sure tbh. Could you ask on the dev list for some advice?
Ok. Thanks. - pengjianhua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60260/#review178474 ----------------------------------------------------------- On 六月 21, 2017, 3:10 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60260/ > ----------------------------------------------------------- > > (Updated 六月 21, 2017, 3:10 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1659 > https://issues.apache.org/jira/browse/RANGER-1659 > > > Repository: ranger > > > Description > ------- > > Different developers use different log directories in the kms installation > script. Its processing logic is chaotic. We should optimize this logic. > > > Diffs > ----- > > kms/scripts/setup.sh 77d8e80 > > > Diff: https://reviews.apache.org/r/60260/diff/1/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >
