-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60452/#review178959
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On June 27, 2017, 5:47 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60452/
> -----------------------------------------------------------
> 
> (Updated June 27, 2017, 5:47 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, 
> Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1668
>     https://issues.apache.org/jira/browse/RANGER-1668
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> ranger_hadoop_conf_file=${WEBAPP_ROOT}/WEB-INF/classes/conf/core-site.xml
> 
> The ranger_hadoop_conf_file variable had been defined and equaled to 
> ${WEBAPP_ROOT}/WEB-INF/classes/conf/core-site.xml. So repeated 
> ${WEBAPP_ROOT}/WEB-INF/classes/conf/core-site.xml should been replaced by 
> ${ranger_hadoop_conf_file} in following code:
> 
> if [ -d ${WEBAPP_ROOT}/WEB-INF/classes/conf ]; then
>    chown -R ${unix_user} ${WEBAPP_ROOT}/WEB-INF/classes/conf
>    if [ "${hadoop_conf}" == "" ]
>    then
>       log "[WARN] Property hadoop_conf not found. Creating blank 
> core-site.xml."
>       echo "<configuration></configuration>" > 
> ${WEBAPP_ROOT}/WEB-INF/classes/conf/core-site.xml
>       else
>       if [ -f ${hadoop_conf_file} ]; then
>                ln -sf ${hadoop_conf_file} 
> ${WEBAPP_ROOT}/WEB-INF/classes/conf/core-site.xml
>         else
>                log "[WARN] core-site.xml file not found in provided 
> hadoop_conf path. Creating blank core-site.xml"
>               echo "<configuration></configuration>" > 
> ${WEBAPP_ROOT}/WEB-INF/classes/conf/core-site.xml
>           fi
>      fi
> fi
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/setup.sh f49bb13 
> 
> 
> Diff: https://reviews.apache.org/r/60452/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Reply via email to