----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60680/#review179770 -----------------------------------------------------------
Ship it! Ship It! - Qiang Zhang On 七月 6, 2017, 8:26 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60680/ > ----------------------------------------------------------- > > (Updated 七月 6, 2017, 8:26 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1677 > https://issues.apache.org/jira/browse/RANGER-1677 > > > Repository: ranger > > > Description > ------- > > The BaseClient class used following code to login user. > String encryptedPwd = configHolder.getPassword(); > String password = PasswordUtils.decryptPassword(encryptedPwd); > if ( configHolder.isKerberosAuthentication() ) > { LOG.info("Init Login: using username/password"); loginSubject = > SecureClientLogin.loginUserWithPassword(userName, password); } > else > { LOG.info("Init Login: security not enabled, using username"); loginSubject > = SecureClientLogin.login(userName); } > But the encrypt function was removed by RANGER-1571 in HadoopConfigHolder > class. > String plainTextPwd = prop.getProperty(RANGER_LOGIN_PASSWORD); > try { - password = PasswordUtils.encryptPassword(plainTextPwd); - > } > catch (IOException e) > { - throw new HadoopException("Unable to initialize login info", e); - > } > - > + password = prop.getProperty(RANGER_LOGIN_PASSWORD); > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopConfigHolder.java > fd925aa > > > Diff: https://reviews.apache.org/r/60680/diff/1/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >
