----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60421/#review180900 -----------------------------------------------------------
unixauthservice/scripts/templates/installprop2xml.properties Line 14 (original), 14 (patched) <https://reviews.apache.org/r/60421/#comment256226> Patch fails to apply. Can you update the patch? $ git apply --check -v < ~/Downloads/RANGER-1491-master-02.patch Checking patch security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java... Checking patch security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java... Hunk #2 succeeded at 563 (offset -3 lines). Hunk #3 succeeded at 574 (offset -3 lines). Hunk #4 succeeded at 618 (offset -3 lines). Hunk #5 succeeded at 1291 (offset -3 lines). Checking patch security-admin/src/main/java/org/apache/ranger/service/XUserService.java... Checking patch security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java... Checking patch security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java... Checking patch ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java... Checking patch ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java... Checking patch ugsync/src/main/java/org/apache/ranger/unixusersync/model/MUserInfo.java... Checking patch ugsync/src/main/java/org/apache/ranger/unixusersync/model/XUserInfo.java... Checking patch unixauthservice/scripts/install.properties... Hunk #1 succeeded at 69 (offset 4 lines). Checking patch unixauthservice/scripts/setup.py... Checking patch unixauthservice/scripts/templates/installprop2xml.properties... error: while searching for: POLICY_MGR_URL = ranger.usersync.policymanager.baseURL MIN_UNIX_USER_ID_TO_SYNC = ranger.usersync.unix.minUserId SYNC_INTERVAL = ranger.usersync.sleeptimeinmillisbetweensynccycle SYNC_LDAP_URL = ranger.usersync.ldap.url SYNC_LDAP_BIND_DN = ranger.usersync.ldap.binddn SYNC_LDAP_BIND_PASSWORD = ranger.usersync.ldap.ldapbindpassword error: patch failed: unixauthservice/scripts/templates/installprop2xml.properties:16 error: unixauthservice/scripts/templates/installprop2xml.properties: patch does not apply Checking patch unixauthservice/scripts/templates/ranger-ugsync-template.xml... Hunk #1 succeeded at 209 (offset 4 lines). - Velmurugan Periasamy On July 11, 2017, 5:52 a.m., bhavik patel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60421/ > ----------------------------------------------------------- > > (Updated July 11, 2017, 5:52 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan > Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1491 > https://issues.apache.org/jira/browse/RANGER-1491 > > > Repository: ranger > > > Description > ------- > > Currently when Ranger connect to external LDAP server than users are > synchronised and they will get default as "User" role. > > It would be a good feature to introduce a mechanism to automatically map > certain users (e.g. they are in a specific group) to "Administrator" or > "Keyadmin" role rather than setting as default "User" role. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 6f77832 > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java b973b9a > security-admin/src/main/java/org/apache/ranger/service/XUserService.java > de95138 > security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java 5e0ca20 > security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java > 9846f67 > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java > 428ad30 > > ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java > 19343b2 > ugsync/src/main/java/org/apache/ranger/unixusersync/model/MUserInfo.java > 841bac6 > ugsync/src/main/java/org/apache/ranger/unixusersync/model/XUserInfo.java > 7d636fd > unixauthservice/scripts/install.properties 13ae1e5 > unixauthservice/scripts/setup.py bbc9226 > unixauthservice/scripts/templates/installprop2xml.properties 1a9bf36 > unixauthservice/scripts/templates/ranger-ugsync-template.xml 0025dc8 > > > Diff: https://reviews.apache.org/r/60421/diff/2/ > > > Testing > ------- > > 1. Verified when ranger-admin connect to LDAP server than users are > synchronised form there they got same role which is specified in > usersync-side. > 2. Verified unix authentication and usersync. > > > Thanks, > > bhavik patel > >
