> On 七月 28, 2017, 4:03 p.m., Colm O hEigeartaigh wrote:
> > The "else" after the initial "if (principal == null) {" is not necessary.Thanks for you advise ,I had modify the code and add test for this feature ,Please review again. - pengjianhua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61202/#review181680 ----------------------------------------------------------- On 七月 31, 2017, 2:15 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61202/ > ----------------------------------------------------------- > > (Updated 七月 31, 2017, 2:15 a.m.) > > > Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, and Qiang > Zhang. > > > Bugs: RANGER-1669 > https://issues.apache.org/jira/browse/RANGER-1669 > > > Repository: ranger > > > Description > ------- > > New Defects reported by Coverity Scan for Apache Ranger > Please find the latest report on new defect(s) introduced to Apache Ranger > found with Coverity Scan. > Null pointer dereferences (NULL_RETURNS) > >>> CID 166074: Null pointer dereferences (NULL_RETURNS) > >>> Calling a method on null object "msObjPrivs". > 1474 for (HiveObjectPrivilege msObjPriv : msObjPrivs) { > 1475 HivePrincipal resPrincipal = new HivePrincipal( > 1476 msObjPriv.getPrincipalName(), > 1477 > AuthorizationUtils.getHivePrincipalType(msObjPriv > 1478 .getPrincipalType())); > > Reason: Hi, Hive also has this problem, > Update patch solved this prolem for hive-plugin(Ranger-1669). > hdfs-plugin has solved by Abhay (Ranger-1695)please review again.thanks. > > > Diffs > ----- > > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > 6872e50 > > hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java > 011d2c3 > > > Diff: https://reviews.apache.org/r/61202/diff/2/ > > > Testing > ------- > > tested it > > > Thanks, > > pengjianhua > >
