----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58268/#review182130 -----------------------------------------------------------
Ship it! Ship It! - Ramesh Mani On April 25, 2017, 2:54 p.m., Yan Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58268/ > ----------------------------------------------------------- > > (Updated April 25, 2017, 2:54 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1501 > https://issues.apache.org/jira/browse/RANGER-1501 > > > Repository: ranger > > > Description > ------- > > The reason is that HDFS file stream's flush() call does not really flush the > data all the way to disk, nor even makes the data visible to HDFS users. See > the HDFS semantics of the flush/sync at > https://issues.apache.org/jira/browse/HADOOP-6313. > Consequently the audit logs on HDFS won't be visible/durable from HDFS client > until the log file is closed. This will, among other issues, boost chances of > losing audit logs in case of system failure. > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java > 889b6ffd > > > Diff: https://reviews.apache.org/r/58268/diff/1/ > > > Testing > ------- > > Automated and manual > > > Thanks, > > Yan Zhou > >
