----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61395/#review182198 -----------------------------------------------------------
Ship it! Ship It! - Colm O hEigeartaigh On Aug. 3, 2017, 2:05 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61395/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2017, 2:05 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1723 > https://issues.apache.org/jira/browse/RANGER-1723 > > > Repository: ranger > > > Description > ------- > > In the HttpSolrClient class of solr5, the setMaxRetries function is > deprecated, and the realization of this function is empty, as follow > /** > * @deprecated retries should be implemented in client code, and should be > considered carefully per-request > */ > public void setMaxRetries(int maxRetries) { } > Then the setMaxRetries function has been removed in the HttpSolrClient class > of solr6, which causes ranger to fail to compile. > So we should remove the places that reference the setMaxRetries function. > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/provider/solr/SolrAuditProvider.java > 3a4da5a > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java > 89d5f4d > security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java b1f0be4 > > > Diff: https://reviews.apache.org/r/61395/diff/1/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >
