> On Aug. 8, 2017, 4:13 p.m., Colm O hEigeartaigh wrote: > > There's a change in logic I'm a bit unsure about for the "first" case. The > > exception message is now changed from: > > > > msgDesc + errMsg > > > > to > > > > getMessage(exp) + DEFAULT_ERROR_MESSAGE > > > > But the exp is null here, and so this is just DEFAULT_ERROR_MESSAGE.
Ooops. But msgDesc previously had 'Unable to find login username...' message in it, so it is a behaviour changing refactor. I'm going to fix it. - Zsombor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61384/#review182399 ----------------------------------------------------------- On Aug. 4, 2017, 8:22 p.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61384/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2017, 8:22 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1722 > https://issues.apache.org/jira/browse/RANGER-1722 > > > Repository: ranger > > > Description > ------- > > The exception creation code is duplicated unnecessarily, which can be easily > refactored to a simpler solution > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/client/BaseClient.java > e1f9796 > > > Diff: https://reviews.apache.org/r/61384/diff/2/ > > > Testing > ------- > > https://travis-ci.org/gzsombor/ranger/builds/260348900 > > > Thanks, > > Zsombor Gegesy > >
