-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61692/
-----------------------------------------------------------
(Updated Aug. 16, 2017, 1:59 p.m.)
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni,
Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja
Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-1736
https://issues.apache.org/jira/browse/RANGER-1736
Repository: ranger
Description
-------
Good coding practice in Ranger recommended by static code analysis on
1.UserMgr.java
2.XUserMgr.java
3.TestXUserMgr.java
4.LdapPolicyMgrUserGroupBuilder.java
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java f27bfc1
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 676b1e3
security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 6e6be72
ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java
9548ed4
Diff: https://reviews.apache.org/r/61692/diff/1/
Testing
-------
1.Verified when ranger-admin connect to LDAP server than users are synchronised
form there they got same role which is specified in usersync-side.
2.Verified unix authentication and usersync.
3.Junit test was successful
Thanks,
Fatima Khan
