----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61555/#review183419 -----------------------------------------------------------
Fix it, then Ship it! +1 if minor issue of method name change is done. security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java Lines 1076 (patched) <https://reviews.apache.org/r/61555/#comment259432> Minor change - no plural needed. it can be deleteSingleUserByUserName. - Velmurugan Periasamy On Aug. 10, 2017, 1:28 p.m., Nikhil P wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61555/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2017, 1:28 p.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan > Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1726 > https://issues.apache.org/jira/browse/RANGER-1726 > > > Repository: ranger > > > Description > ------- > > Users are not getting deleted when Knoxproxy is enabled. > Steps - > 1.Enter the knox proxy url- "https://<host-name>:8443/gateway/ui/ranger/" > 2.Login to Ranger with admin credentials. > 3.Go to 'Users/Groups' Page by clicking on 'Users/Groups' button present > under 'Settings' tab. > 4.Click on 'Add New User'. > 5.Enter the details and click on Save. > 6.Select the created user from Users page by selecting the checkbox present > beside username. > 7.Click on delete button. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java ca06805 > security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 6e9161e > security-admin/src/main/webapp/scripts/model_bases/VXGroupBase.js 96e0946 > security-admin/src/main/webapp/scripts/model_bases/VXUserBase.js db6d511 > security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js > 8e465d7 > > > Diff: https://reviews.apache.org/r/61555/diff/1/ > > > Testing > ------- > > 1.Verified if users are getting deleted when knox proxy is enabled. > 2.Verified if multiple users are getting deleted at once. > 3.Verified if users are getting deleted when knox proxy is disabled. > > > Thanks, > > Nikhil P > >
