> On 八月 22, 2017, 1:31 a.m., Velmurugan Periasamy wrote: > > security-admin/scripts/changepasswordutil.py > > Line 34 (original), 34 (patched) > > <https://reviews.apache.org/r/61782/diff/1/?file=1800730#file1800730line34> > > > > Can you please confirm this is tested on both linux and windows after > > the patch?
I carefully test the patch on linux and windows. The RANGER_ADMIN_HOME variable got the desired value. Just now, I once again verified the patch. - Qiang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61782/#review183422 ----------------------------------------------------------- On 八月 21, 2017, 2:05 p.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61782/ > ----------------------------------------------------------- > > (Updated 八月 21, 2017, 2:05 p.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1744 > https://issues.apache.org/jira/browse/RANGER-1744 > > > Repository: ranger > > > Description > ------- > > The assignment logic is inconsistent for the value of the RANGER_ADMIN_HOME > variable in Ranger Admin. If the RANGER_ADMIN_HOME environment variable do > not set, the Ranger Admin is installed using current path in linux. However > the Ranger Admin is installed using empty path in windows. So it will cause a > serious failure in windows system. > > > Diffs > ----- > > security-admin/scripts/changepasswordutil.py 3086962 > security-admin/scripts/changeusernameutil.py 7216bbc > > > Diff: https://reviews.apache.org/r/61782/diff/1/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
