-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61840/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-1747
https://issues.apache.org/jira/browse/RANGER-1747
Repository: ranger
Description
-------
Issue is described in ticket:
https://issues.apache.org/jira/browse/RANGER-1747
This patch fixes the possible copy-paste / typo of: overwriting user specified
pagedResultsSize of PagedResultsControl with the default value of 500 batch
fetch size, in the middle of the pagination iteration.
Diffs
-----
ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java
3168a199
Diff: https://reviews.apache.org/r/61840/diff/1/
Testing
-------
Since the pagination is not part of the state, but is only a runtime option,
asserting for expected number of paginations is not possible. However a debug
level log message is printed at the end of each iteration of the pagination,
with the current pagination round number.
Before the fix:
The first round of pagination is done with the user defined pageSize, and at
the end of the iteration it is overwritten with the default value: 500. The
next round of pagination is with this page size of 500.
After the fix:
Each round uses the use defined page size, and will not get rejected by the
LDAP server.
Thanks,
Endre Zoltan Kovacs
