> On 八月 25, 2017, 7:44 p.m., Velmurugan Periasamy wrote: > > hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java > > Line 289 (original), 289 (patched) > > <https://reviews.apache.org/r/61909/diff/1/?file=1803391#file1803391line289> > > > > Can you explain why this patch is required? In case of HA enabled > > namenode, linking both core-site.xml and hdfs-site.xml under > > /etc/ranger/admin/conf should get test connection feature working fine.
1.It will prompt 'Value for dfs.client.failover.proxy.provider.nameservice1,nameservice2 not specified)' when the user configures the hdfs federation parameter on the page (dfs.nameservices=nameservice1,nameservice2) and tests connection. This is a incorrect prompt. 'dfs.client.failover.proxy.provider.nameservice1,nameservice2' is not a valid configuration item. 2.We need to configure multiple hdfs services when ranger manages multiple clusters of hdfs. How to distinguish hdfs clusters , if I link both core-site.xml and hdfs-site.xml under /etc/ranger/admin/conf. Whether we can only configure on the page - pengjianhua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61909/#review183870 ----------------------------------------------------------- On 八月 25, 2017, 3:09 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61909/ > ----------------------------------------------------------- > > (Updated 八月 25, 2017, 3:09 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1752 > https://issues.apache.org/jira/browse/RANGER-1752 > > > Repository: ranger > > > Description > ------- > > When "dfs.nameservices" configures multiple nameservice id > (dfs.nameservices=nameservice1,nameservice2) and then test hdfs connection, > the code will check > "dfs.client.failover.proxy.provider.nameservice1,nameservice2" to be > mandatory, but this is incorrect. > We should check "dfs.client.failover.proxy.provider.nameservice1" and > "dfs.client.failover.proxy.provider.nameservice2" to be mandatory, > respectively. > Some other configuration items are the same: > dfs.ha.namenodes.[nameservice ID] > dfs.namenode.rpc-address.[nameservice ID] > > > Diffs > ----- > > > hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java > cab1b52e > > > Diff: https://reviews.apache.org/r/61909/diff/1/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >
