----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62023/#review184350 -----------------------------------------------------------
ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java Lines 976 (patched) <https://reviews.apache.org/r/62023/#comment260482> One minor suggestion : Exception is not thrown within the try block and RuntimeException is not explicitly caught. It will be better to explicitly catch RuntimeException as well. ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java Lines 884 (patched) <https://reviews.apache.org/r/62023/#comment260483> Same minor suggestion : Exception is not thrown within the try block and RuntimeException is not explicitly caught. It will be better to explicitly catch RuntimeException as well. - bhavik patel On Sept. 1, 2017, 1:56 a.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62023/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2017, 1:56 a.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan > Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan > Periasamy. > > > Bugs: RANGER-1735 > https://issues.apache.org/jira/browse/RANGER-1735 > > > Repository: ranger > > > Description > ------- > > Initial implementation of evaluating nested group memberships for Ranger > usersyc based on the design mentioned in the apache jira. Modified test ldif > file to include nested groups, updated test config file to enable the nested > group evaluation, and modified few unit tests to cover the new logic. > > > Diffs > ----- > > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java > d27a217 > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java > e62da5b > > ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java > af27efa > ugsync/src/test/java/org/apache/ranger/usergroupsync/TestLdapUserGroup.java > 6ebc311 > ugsync/src/test/resources/ADSchema.ldif a45a2fb > ugsync/src/test/resources/ranger-ugsync-site.xml 7d1c27c > > > Diff: https://reviews.apache.org/r/62023/diff/1/ > > > Testing > ------- > > 1. Tested new functionality with AD server containing few nested groups > 2. Tested for both full sync and delta sync implementations > 3. Performed basic regression testing > 4. Successfully ran all the related unit tests. > > > Thanks, > > Sailaja Polavarapu > >
