----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62029/#review185003 -----------------------------------------------------------
Fix it, then Ship it! security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java Lines 2544 (patched) <https://reviews.apache.org/r/62029/#comment261236> Wouldn't it be helpful to log this at WARN level? - Velmurugan Periasamy On Sept. 1, 2017, 2 p.m., Nikhil P wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62029/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2017, 2 p.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan > Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1750 > https://issues.apache.org/jira/browse/RANGER-1750 > > > Repository: ranger > > > Description > ------- > > In Nifi default policy are getting created with policyitem without any > user/group but permission is set for the same. In ideal case this is not a > valid policyitem. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 9742265 > > > Diff: https://reviews.apache.org/r/62029/diff/1/ > > > Testing > ------- > > 1)tested that during service creation if default policy does not have valid > policyItem then policy wont be created. > 2)tested Nifi policy and service CRUD works properly. > > > Thanks, > > Nikhil P > >
