Thanks! I updated the README to include the enunciate instruction. I don't mind either way regarding whether to include the KMS API on the website or not right now. What is your own view?
Either way, +1 to creating a JIRA to fix the KMS REST API. Colm. On Sat, Sep 9, 2017 at 4:37 AM, Mehul Parikh <[email protected]> wrote: > Hi Colm, > > Please run : "mvn enunciate:docs" and then from docs directory run: "mvn > site". > > > On Sep 8, 2017 8:00 PM, "Colm O hEigeartaigh" <[email protected]> wrote: > > > Hi Mehul, > > > > How are you generating the website? I did a "mvn clean install > > -DskipTests" on the root dir, and "mvn site" in docs, but I still don't > see > > a link being generated for the KMS api-docs? > > > > Colm. > > > > On Fri, Sep 8, 2017 at 10:30 AM, Mehul Parikh <[email protected]> wrote: > > > >> Hi Colm, > >> > >> I have the updated patch ready with docs getting generated for KMS and > >> links are also getting populated for Ranger KMS's REST APIs. > >> > >> However, still, detailed json related docs are are not getting > populated. > >> Looks like : need to make changes in annotations for REST APIs of Ranger > >> KMS. This change will need more testing. > >> > >> Do you want to commit this change and create a separate JIRA for > handling > >> annotations in Ranger KMS REST APIs and provide fix as part of that > JIRA ? > >> > >> Or shall we remove kms api-docs links from website and publish it once > all > >> docs are getting populated for Ranger KMS? > >> > >> > >> > >> > >> On Sat, Sep 2, 2017 at 12:55 PM, Mehul Parikh <[email protected]> > wrote: > >> > >> > Hi Colm, > >> > > >> > I will check for the same and provide a updated patch if needed. > >> > > >> > On Sep 1, 2017 4:15 PM, "Colm O hEigeartaigh" <[email protected]> > >> wrote: > >> > > >> >> Hi Mehul, > >> >> > >> >> I've recently updated the website and I've noticed a few issues > >> relating > >> >> to the patch you did for RANGER-1651. > >> >> > >> >> The "apidocs" only appear in the target directory of "docs" if you > do a > >> >> mvn install from the root directory, so I updated the README in the > >> docs > >> >> folder to clarify this. > >> >> The website is now live with: > >> >> > >> >> http://ranger.apache.org/apidocs/index.html > >> >> > >> >> However, the following link which you added is broken: > >> >> > >> >> http://ranger.apache.org/kms/apidocs/index.html > >> >> > >> >> The KMS apidocs are not added to the website as part of mvn site > that I > >> >> can see. Did you get this working locally? Or should we just remove > the > >> >> link to the KMS apidocs from the website? > >> >> > >> >> Colm. > >> >> > >> >> -- > >> >> Colm O hEigeartaigh > >> >> > >> >> Talend Community Coder > >> >> http://coders.talend.com > >> >> > >> > > >> > >> > >> -- > >> > >> Thanks and regards, > >> Mehul Parikh > >> ---------------------------- > >> M: +91 98191 54446 > >> E: [email protected] > >> > > > > > > > > -- > > Colm O hEigeartaigh > > > > Talend Community Coder > > http://coders.talend.com > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com
