-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62233/
-----------------------------------------------------------
(Updated Sept. 12, 2017, 12:34 p.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan
Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1732
https://issues.apache.org/jira/browse/RANGER-1732
Repository: ranger
Description
-------
Hi
In a recent github mirror, I've found suspicious code.
Branch: master
Path:
agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerMultiResourceAuditHandler.java
32 Collection<AuthzAuditEvent> auditEvents = new ArrayList<>();
...
42
43 @Override
44 public void logAuthzAudits(Collection<AuthzAuditEvent> auditEvents)
{
45 auditEvents.addAll(auditEvents);
46 }
In Line 45, `auditEvents.addAll' should be `this.auditEvents.addAll'? This
might not be an issue but I wanted to report just in case.
Thanks!
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerMultiResourceAuditHandler.java
9990dd4c
Diff: https://reviews.apache.org/r/62233/diff/1/
Testing
-------
Thanks,
pengjianhua
