----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62264/#review185388 -----------------------------------------------------------
Ship it! Ship It! - Colm O hEigeartaigh On Sept. 13, 2017, 9:01 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62264/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2017, 9:01 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1776 > https://issues.apache.org/jira/browse/RANGER-1776 > > > Repository: ranger > > > Description > ------- > > Ranger always show error , the reason is logJSON always return false : > AuditFileSpool.java > ret = consumerProvider.logJSON(lines); > if (!ret) { > // Need to log error after fixed interval > logError("Error sending logs to consumer. > provider=" > + queueProvider.getName() + ", > consumer=" > + consumerProvider.getName()); > } else { > .... .... > } > BufferedAuditProvider.java > @Override > public boolean logJSON(Collection<String> events) { > boolean ret = true; > for (String event : events) { > ret = logJSON(event); > if (!ret) { > break; > } > } > return false; > } > > Here should return ret . > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/provider/BufferedAuditProvider.java > 31b171e9 > > > Diff: https://reviews.apache.org/r/62264/diff/1/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >
