-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62325/#review185397
-----------------------------------------------------------
Please fix it.
Applying: RANGER-1778 The logical of the policy details for Ranger Hive Plugin
is error.
.git/rebase-apply/patch:24: space before tab in indent.
var perms = [];
.git/rebase-apply/patch:25: space before tab in indent.
var permsIds = [];
.git/rebase-apply/patch:26: space before tab in indent.
for(var i = 0;i<this.perms.length;i++){
.git/rebase-apply/patch:27: space before tab in indent.
if(this.resourceType=="url"&&(this.perms[i].value=="read"||this.perms[i].value=="write")||(this.resourceType=="database"&&this.perms[i].value!="read"&&this.perms[i].value!="write")){
.git/rebase-apply/patch:33: space before tab in indent.
}
warning: squelched 4 whitespace errors
warning: 9 lines add whitespace errors.
- Qiang Zhang
On Sept. 14, 2017, 10:41 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62325/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2017, 10:41 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1778
> https://issues.apache.org/jira/browse/RANGER-1778
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The current logic is as following:
> 1?If policy choose “database”, the Permissions can choose "Read" and "Write"
> 2?If policy choose “url”, the Permissions can not choose "Read" and "Write"
> Above logic is error. The right logic should be as following:
> 1?If policy choose “database”, the Permissions can not choose "Read" and
> "Write"
> 2?If policy choose “url”, the Permissions can only choose "Read" and "Write"
> 3?Control relation values between "database" and "url" when user switched
> them.That is, we should control the linkage of the switch for "database" and
> "url".
> Please refer to
> https://community.hortonworks.com/questions/135781/ranger-hive-read-and-write-permissions.html
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js
> bb649840
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js
> 9a8d82db
>
>
> Diff: https://reviews.apache.org/r/62325/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
