----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62430/#review185778 -----------------------------------------------------------
Ship it! Ship It! - Qiang Zhang On 九月 20, 2017, 8:10 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62430/ > ----------------------------------------------------------- > > (Updated 九月 20, 2017, 8:10 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1794 > https://issues.apache.org/jira/browse/RANGER-1794 > > > Repository: ranger > > > Description > ------- > > if(! StringUtils.isEmpty(serviceType)) { > RangerServiceDef serviceDef = svcStore == null ? null : > svcStore.getServiceDefByName(serviceType); > if(serviceDef != null) { > Class<RangerBaseService> cls = > getClassForServiceType(serviceDef); > if(cls != null) { > ret = cls.newInstance(); > ret.init(serviceDef, service); > if(ret instanceof RangerServiceTag) { > ((RangerServiceTag)ret).setTagStore(tagStore); > } > } else { > LOG.warn("ServiceMgr.getRangerServiceByService(" + > service + "): could not find service class '" + serviceDef.getImplClass() + > "'"); > } > } else { > LOG.warn("ServiceMgr.getRangerServiceByService(" + service + > "): could not find the service-type '" + serviceType + "'"); > } > } else { > LOG.warn("ServiceMgr.getRangerServiceByService(" + service + "): could > not find the service-type"); > } > The above code should be modified as following: > if(! StringUtils.isEmpty(serviceType)) { > RangerServiceDef serviceDef = svcStore == null ? null : > svcStore.getServiceDefByName(serviceType); > if(serviceDef != null) { > Class<RangerBaseService> cls = > getClassForServiceType(serviceDef); > if(cls != null) { > ret = cls.newInstance(); > ret.init(serviceDef, service); > if(ret instanceof RangerServiceTag) { > ((RangerServiceTag)ret).setTagStore(tagStore); > } > } else { > LOG.warn("ServiceMgr.getRangerServiceByService(" + > service + "): could not find service class '" + serviceDef.getImplClass() + > "'"); > } > } else { > LOG.warn("ServiceMgr.getRangerServiceByService(" + service + > "): could not find the service-def"); > } > } else { > LOG.warn("ServiceMgr.getRangerServiceByService(" + service + "): could > not find the service-type '" + serviceType + "'"); > } > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 722a5662 > > > Diff: https://reviews.apache.org/r/62430/diff/1/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >
