----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62024/#review185830 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java Line 351 (original), 357 (patched) <https://reviews.apache.org/r/62024/#comment262181> This patch fails unit tests. Can you address the issue and provide an updated patch? ``` Tests run: 112, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.92 sec <<< FAILURE! - in org.apache.ranger.rest.TestXUserREST test24searchXUsers(org.apache.ranger.rest.TestXUserREST) Time elapsed: 0.01 sec <<< ERROR! java.lang.NullPointerException: null at org.apache.ranger.rest.XUserREST.searchXUsers(XUserREST.java:357) at org.apache.ranger.rest.TestXUserREST.test24searchXUsers(TestXUserREST.java:517) ``` - Velmurugan Periasamy On Sept. 20, 2017, 10:25 a.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62024/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2017, 10:25 a.m.) > > > Review request for ranger, Ankita Sinha, Fatima Khan, Gautam Borad, Mehul > Parikh, and Velmurugan Periasamy. > > > Bugs: RANGER-1756 > https://issues.apache.org/jira/browse/RANGER-1756 > > > Repository: ranger > > > Description > ------- > > Handle role related restrictions for users having User role. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 739ea05 > security-admin/src/main/webapp/scripts/utils/XAUtils.js ecf43ad > > > Diff: https://reviews.apache.org/r/62024/diff/2/ > > > Testing > ------- > > Verified scenario's : > 1. A user with ROLE_ADMIN able to see users which has USER_ROLE/ADMIN_ROLE. > 2. A user with ROLE_KEYADMIN able to see users which has > USER_ROLE/KEYADMIN_ROLE. > 3. A user with role ROLE_USER able to see only himself. > > > Thanks, > > Nitin Galave > >
