----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62521/#review186230 -----------------------------------------------------------
Ship it! Ship It! - Colm O hEigeartaigh On Sept. 25, 2017, 7:15 a.m., wang yuan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62521/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2017, 7:15 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1803 > https://issues.apache.org/jira/browse/RANGER-1803 > > > Repository: ranger > > > Description > ------- > > For test_resourcematcher_default.json, there is one more comma at last line. > I think the comma in end line should be deleled,otherwise may be analysis a > null value. > For example: > "tests":[ > { "name":"all-lower","input":"simple", "result":true}, > ... ... > ... ... > { "name":"invalid-mixed-case-wild","input":"OtHeR-SiMpLe", > "result":false}, > ###{ "name":"invalid-mixed-case-wild","input":"OtHeR-SiMpLe", > "result":false} > ] > "tests":[ > { "name":"all-lower","input":"simple", "result":true}, > ... ... > ... ... > { "name":"invalid-mixed-case","input":"oThEr-StRiNg", > "result":false}, > ###{ "name":"invalid-mixed-case","input":"oThEr-StRiNg", > "result":false} > ] > > > Diffs > ----- > > > agents-common/src/test/resources/resourcematcher/test_resourcematcher_default.json > 50b4cc32 > > > Diff: https://reviews.apache.org/r/62521/diff/2/ > > > Testing > ------- > > > Thanks, > > wang yuan > >
