----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62398/#review186236 -----------------------------------------------------------
Ship it! Ship It! - Qiang Zhang On 九月 21, 2017, 8:47 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62398/ > ----------------------------------------------------------- > > (Updated 九月 21, 2017, 8:47 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1790 > https://issues.apache.org/jira/browse/RANGER-1790 > > > Repository: ranger > > > Description > ------- > > The current logic is as following: > 1. Other checkbox will be selected when the "Select checkbox" was selected. > 2. Other checkbox will be deselected when the "Deselect checkbox" was > selected. > 3. The "Select / Deselect All" checkbox was not automatically selected when > all checkbox were Selected. > 4. The "Select / Deselect All" checkbox was not automatically deselected when > all checkbox were deselected. > The right logic should be as following: > 1. Other checkbox will be selected when the "Select checkbox" was selected. > 2. Other checkbox will be deselected when the "Deselect checkbox" was > selected. > 3. The "Select / Deselect All" checkbox was automatically selected when all > checkbox were Selected. > 4. The "Select / Deselect All" checkbox was automatically deselected when all > checkbox were deselected. > Please refer to select-all-permissions.png and select-all-permissions-01.png. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/views/policies/PermissionList.js > 0803945e > > > Diff: https://reviews.apache.org/r/62398/diff/1/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >
