-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62686/#review186666
-----------------------------------------------------------
I think it's better to pass the exception as an argument and not implicitly
call toString(), e.g. logger.error("Get transaction log failure.", illegalAcc);
Also change "Get transaction log failure" to just "Transaction log failure"
- Colm O hEigeartaigh
On Sept. 29, 2017, 9:05 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62686/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2017, 9:05 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, pengjianhua,
> and Ramesh Mani.
>
>
> Bugs: RANGER-1816
> https://issues.apache.org/jira/browse/RANGER-1816
>
>
> Repository: ranger
>
>
> Description
> -------
>
> these java files are as follows:
> RangerPolicyService.java
> XGroupService.java
> XUserService.java
>
>
> Diffs
> -----
>
>
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java
> f55a103
> security-admin/src/main/java/org/apache/ranger/service/XGroupService.java
> fd57430
> security-admin/src/main/java/org/apache/ranger/service/XUserService.java
> 9be833c
>
>
> Diff: https://reviews.apache.org/r/62686/diff/1/
>
>
> Testing
> -------
>
> Tested!
>
>
> Thanks,
>
> Qiang Zhang
>
>
