-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63016/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Don Bosco Durai, bhavik patel, Gautam 
Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan 
Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1838
    https://issues.apache.org/jira/browse/RANGER-1838


Repository: ranger


Description
-------

**Problem Statement:** Ranger code is having CSVFormatter class which is using 
javacsv API. Since JiSQL code is not using CSVFormatter class so its dependency 
on javacsv API can be removed.

**Proposed Solution:** Remove formatData method implementation from 
CSVFormatter class. 
Remove dependency of javacsv API from pom.xml and distribution of javacsv API 
can be removed from admin-web.xml and kms.xml


Diffs
-----

  jisql/pom.xml efb1dff 
  jisql/src/main/java/org/apache/util/outputformatter/CSVFormatter.java 158e25c 
  jisql/src/main/java/org/apache/util/sql/Jisql.java cf5f2c4 
  src/main/assembly/admin-web.xml 0e97818 
  src/main/assembly/kms.xml 1d7116a 


Diff: https://reviews.apache.org/r/63016/diff/1/


Testing
-------

**Steps performed for Ranger-admin(with patch):**
1. Created Build with patch and untar the build.
2. Opened install.properties and provided db configuration in install.properties
3. Called setup.sh

**Expected Behavior:**
Ranger-admin installation should finish successfully.

**Actual Behavior:**
Ranger-admin Installation finished successfully.

------
**Steps performed for Ranger-KMS(with patch):**
1. Created Build with patch and untar the build.
2. Opened install.properties and provided db configuration in install.properties
3. Called setup.sh

**Expected Behavior:**
Ranger-KMS installation should finish successfully.

**Actual Behavior:**
Ranger-KMS Installation finished successfully.

-----------
**NOTE:** Below steps have been tested for all db flavor.


Thanks,

Pradeep Agrawal

Reply via email to