> On 十月 19, 2017, 5:51 p.m., Alejandro Fernandez wrote: > > security-admin/scripts/setup.sh > > Line 305 (original), 304 (patched) > > <https://reviews.apache.org/r/63145/diff/1/?file=1863590#file1863590line305> > > > > This will not work if the minor version ever changes to 2 digits, e.g., > > 1.10.0_1 > > > > Instead, concatenate > > export java_major_minor="$major.$minor" > > > > if [[ "$java_major_minor" != "$JAVA_VERSION_REQUIRED" ]]; then > > ...
You are right. I fixed it and updated the patch. Thanks! - pengjianhua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63145/#review188713 ----------------------------------------------------------- On 十月 19, 2017, 1 p.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63145/ > ----------------------------------------------------------- > > (Updated 十月 19, 2017, 1 p.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1846 > https://issues.apache.org/jira/browse/RANGER-1846 > > > Repository: ranger > > > Description > ------- > > The java version must be equal to or more than 1.8 when we set db_ssl_enabled > equal to true. > This JAVA_VERSION_REQUIRED configuration item is invalid in security admin > installer, we should enable it to control the necessary java version. > > > Diffs > ----- > > security-admin/scripts/setup.sh e2a69b71 > > > Diff: https://reviews.apache.org/r/63145/diff/1/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >
