----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63216/#review188938 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On Oct. 23, 2017, 2:21 p.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63216/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2017, 2:21 p.m.) > > > Review request for ranger, Gautam Borad, Mehul Parikh, and Velmurugan > Periasamy. > > > Bugs: RANGER-1853 > https://issues.apache.org/jira/browse/RANGER-1853 > > > Repository: ranger > > > Description > ------- > > When a custom masking function is written which uses strings that need to be > quote in the UI, the quotes in the string are not unescaped properly. When > the policy with such incorrectly escaped stings is saved and executed, any > Hive queries that invoke this policy fail to parse causing Hive query to > throw a syntax error. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/views/policies/PermissionList.js > 73ea8fe > > > Diff: https://reviews.apache.org/r/63216/diff/1/ > > > Testing > ------- > > 1.Verified Policy CRUD using single quotes in the masking policy condition > working as expected i.e not escaping single quote after saving the policy. > 2.Verified policy difference view for that policy (i.e in Audit Menu --> > Admin tab). > 3.Also verified policy enforcement for custom masking condition. > > > Thanks, > > Nitin Galave > >
