----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63552/#review190084 -----------------------------------------------------------
agents-audit/README.txt Lines 44 (patched) <https://reviews.apache.org/r/63552/#comment267338> Please clarify if this query needs to be run as a part of Audit framework set-up. agents-audit/README.txt Lines 68 (patched) <https://reviews.apache.org/r/63552/#comment267339> Is the location hard-coded to /ranger/audit/hdfs? or is it configured through some other configuration variable? agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCWriter.java Lines 108 (patched) <https://reviews.apache.org/r/63552/#comment267341> Clarification needed: Does this method log all events passed to it as one ORC batch? If so, then if the number of events passed is much smaller than the optimal batch-size, there may be smaller batches created. agents-audit/src/main/java/org/apache/ranger/audit/utils/Writer.java Lines 26 (patched) <https://reviews.apache.org/r/63552/#comment267340> Spelling.. writer->write - Abhay Kulkarni On Nov. 4, 2017, 12:38 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63552/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2017, 12:38 a.m.) > > > Review request for ranger, Don Bosco Durai and Madhan Neethiraj. > > > Repository: ranger > > > Description > ------- > > RANGER-1837:Enhance Ranger Audit to HDFS to support ORC file format > > > Diffs > ----- > > agents-audit/README.txt PRE-CREATION > agents-audit/pom.xml c8bd1d8 > > agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java > 66d8504 > > agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditFileCacheProvider.java > 314b130 > agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java > eff3824 > agents-audit/src/main/java/org/apache/ranger/audit/utils/AuditWriter.java > PRE-CREATION > agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCFileUtil.java > PRE-CREATION > agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCWriter.java > PRE-CREATION > agents-audit/src/main/java/org/apache/ranger/audit/utils/TextWriter.java > PRE-CREATION > agents-audit/src/main/java/org/apache/ranger/audit/utils/Writer.java > PRE-CREATION > pom.xml 589cd6a > src/main/assembly/hbase-agent.xml 3ebc334 > src/main/assembly/hdfs-agent.xml 5279a9a > src/main/assembly/hive-agent.xml ca65c80 > src/main/assembly/knox-agent.xml 8357d49 > src/main/assembly/plugin-atlas.xml fd98811 > src/main/assembly/plugin-kafka.xml 95855d9 > src/main/assembly/plugin-kms.xml 6d15f2a > src/main/assembly/plugin-solr.xml de30bfb > src/main/assembly/plugin-sqoop.xml d2bd69a > src/main/assembly/plugin-yarn.xml c6a48e8 > src/main/assembly/storm-agent.xml 64224ec > > > Diff: https://reviews.apache.org/r/63552/diff/3/ > > > Testing > ------- > > Testing done in local > > > Thanks, > > Ramesh Mani > >
