----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63919/#review191356 -----------------------------------------------------------
Ship it! Makes sense, less dependency is always better. - Zsombor Gegesy On Nov. 17, 2017, 3:23 p.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63919/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2017, 3:23 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1895 > https://issues.apache.org/jira/browse/RANGER-1895 > > > Repository: ranger > > > Description > ------- > > This task is to simplify the Apache Storm dependencies for Ranger. We are > shipping the hadoop-hdfs jar, which is not required. Secondly, we can avoid > explicitly listing some of the dependencies, as they get pulled in via other > dependencies. > > > Diffs > ----- > > src/main/assembly/storm-agent.xml 64224ec7 > storm-agent/pom.xml 6e74e5b3 > > > Diff: https://reviews.apache.org/r/63919/diff/1/ > > > Testing > ------- > > Tested the plugin works OK with Apache Storm 1.1.1. The only change in the > distribution is that it doesn't include the Hadoop HDFS jar. > > > Thanks, > > Colm O hEigeartaigh > >
