----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64293/#review192692 -----------------------------------------------------------
Ship it! Ship It! - Colm O hEigeartaigh On Dec. 4, 2017, 8:30 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64293/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2017, 8:30 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1914 > https://issues.apache.org/jira/browse/RANGER-1914 > > > Repository: ranger > > > Description > ------- > > Code: if (crypt_algo_array != null && crypt_algo_array.length > 1) > when crypt_algo_array.length<5 password = crypt_algo_array[4]; will case > java.lang.ArrayIndexOutOfBoundsException. > Change from "if (crypt_algo_array != null && crypt_algo_array.length > 1)" > to "if (crypt_algo_array != null && crypt_algo_array.length > 4)". > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java > 58cdd35 > > > Diff: https://reviews.apache.org/r/64293/diff/1/ > > > Testing > ------- > > Tested it. > > > Thanks, > > pengjianhua > >
