-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64404/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O
hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan
Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1918
https://issues.apache.org/jira/browse/RANGER-1918
Repository: ranger
Description
-------
1.We have already determined the logic of the response! = Null and
response.getStatus ()! = 200 in the getQueueResponse method, and do not need to
be evaluated in the run method of the getQueueResponse method. Move
"response.close ();" into the getQueueResponse method.
2.There is no necessary to create so many useless temporary variables "String
errMsg = errMessage;"
just use errMessage is better practice.
Diffs
-----
plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnClient.java
b61a07e
Diff: https://reviews.apache.org/r/64404/diff/1/
Testing
-------
Thanks,
pengjianhua
