----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64189/#review193207 -----------------------------------------------------------
Fix it, then Ship it! tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java Line 180 (original), 208 (patched) <https://reviews.apache.org/r/64189/#comment271757> "Info" ==> "Debug". Also in line #210 below. - Madhan Neethiraj On Dec. 8, 2017, 1:04 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64189/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2017, 1:04 a.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1897 > https://issues.apache.org/jira/browse/RANGER-1897 > > > Repository: ranger > > > Description > ------- > > Currently tag-synchronization via REST API method uses Atlas V1 APIs, which > requires large number of calls from Ranger tag-sync to Atlas server. In > environments having large number of entities, this approach can take a long > time to download tags from Atlas. Use of Atlas V2 APIs would significantly > improve the performance. > > > Diffs > ----- > > > plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasResource.java > f056f3e > pom.xml c603d66 > src/main/assembly/tagsync.xml 0b17151 > tagsync/pom.xml 74ff155 > > tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java > b07cd34 > > tagsync/src/main/java/org/apache/ranger/tagsync/sink/tagadmin/TagAdminRESTSink.java > c34b6ea > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasEntityWithTraits.java > 77dee01 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasHbaseResourceMapper.java > 8b36a31 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasHdfsResourceMapper.java > 06bff90 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasHiveResourceMapper.java > a359622 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasKafkaResourceMapper.java > 09ae5d1 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java > f007ae5 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapper.java > 8ececdf > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java > 40a639b > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasStormResourceMapper.java > 4ed01ca > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java > c382db0 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java > 4e0ae90 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTUtil.java > 00a101e > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/RangerAtlasEntity.java > PRE-CREATION > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/RangerAtlasEntityWithTags.java > PRE-CREATION > > tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHbaseResourceMapper.java > e990c28 > > tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHdfsResourceMapper.java > 392b096 > > tagsync/src/test/java/org/apache/ranger/tagsync/process/TestHiveResourceMapper.java > 7fde91a > > tagsync/src/test/java/org/apache/ranger/tagsync/process/TestKafkaResourceMapper.java > 3beb82f > > > Diff: https://reviews.apache.org/r/64189/diff/5/ > > > Testing > ------- > > Tested in local VM. > > > Thanks, > > Abhay Kulkarni > >
