----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64753/#review194282 -----------------------------------------------------------
hdfs-agent/pom.xml Line 36 (original), 37 (patched) <https://reviews.apache.org/r/64753/#comment273021> Given ranger-hdfs-plugin doesn't depend on its shim, it will be cleaner to not have this dependency here. hdfs-agent/pom.xml Lines 116 (patched) <https://reviews.apache.org/r/64753/#comment273025> hadoop libraries (like hadoop-common, hadoop-auth, should already be present in NameNode classpath. We shouldn't have to package them in ranger-hdfs-plugin. Please review. src/main/assembly/hdfs-agent.xml Line 47 (original) <https://reviews.apache.org/r/64753/#comment273027> These files are needed in install/lib directory for the manuall installation to work. If this library list changes, please ensure that manuall installation works correctly. - Madhan Neethiraj On Dec. 20, 2017, 7:04 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64753/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2017, 7:04 p.m.) > > > Review request for ranger, Madhan Neethiraj and Selvamohan Neethiraj. > > > Bugs: RANGER-1939 > https://issues.apache.org/jira/browse/RANGER-1939 > > > Repository: ranger > > > Description > ------- > > There are two issues with the Maven POM files for Ranger's hdfs plugin module. > 1. There are overlapping and sometimes conflicting versions of libraries on > which hdfs plugin code depends. Conflicts arise partly because some of the > libraries packaged with hdfs plugin module are already exist in hdfs > component and have different versions. > 2. assembly specification for hdfs plugin module uses DependencySets - a > construct which is confusing and hard to get right. They also clutter up > build output log with spurious messages. It is desirable to use FileSets > which are easier to understand and straightforward to specify in an assembly > spec. > > > Diffs > ----- > > hdfs-agent/pom.xml e9b2b59 > pom.xml 255b02a > src/main/assembly/hdfs-agent.xml 561d137 > > > Diff: https://reviews.apache.org/r/64753/diff/1/ > > > Testing > ------- > > Tested with local VM > > > Thanks, > > Abhay Kulkarni > >
