----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64764/#review194410 -----------------------------------------------------------
Ship it! Ship It! - Qiang Zhang On Dec. 21, 2017, 3:06 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64764/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2017, 3:06 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1941 > https://issues.apache.org/jira/browse/RANGER-1941 > > > Repository: ranger > > > Description > ------- > > We have defined the method of log printing in the > RangerScriptExecutionContext class. Why not use these methods in this class, > use the defined method logDebug logError instead of LOG.debug and LOG.error > to keep the code style and optimize the log printing. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java > 0c8df41 > > > Diff: https://reviews.apache.org/r/64764/diff/1/ > > > Testing > ------- > > Tested it. > > > Thanks, > > pengjianhua > >
