----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64926/#review194714 -----------------------------------------------------------
plugin-yarn/src/main/java/org/apache/ranger/services/yarn/RangerServiceYarn.java Line 25 (original), 25 (patched) <https://reviews.apache.org/r/64926/#comment273645> Abhay - this fails with PMD violations. could you please fix them? ``` [INFO] --- maven-pmd-plugin:3.7:check (default) @ ranger-yarn-plugin --- [INFO] PMD Failure: org/apache/ranger/services/yarn/RangerServiceYarn.java:25 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.commons.lang.StringUtils'. [INFO] PMD Failure: org/apache/ranger/services/yarn/RangerServiceYarn.java:31 Rule:UnusedImports Priority:4 Avoid unused imports such as 'org.apache.ranger.plugin.resourcematcher.RangerPathResourceMatcher'. ``` - Velmurugan Periasamy On Jan. 3, 2018, 8:28 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64926/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2018, 8:28 p.m.) > > > Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan > Periasamy. > > > Bugs: RANGER-1932 > https://issues.apache.org/jira/browse/RANGER-1932 > > > Repository: ranger > > > Description > ------- > > Default YARN policy, created when a YARN service is created, has ".*" as the > policy-value. As this policy needs to match all possible queues, it should > have "*" as the policy-value. > > This patch should fix an earlier incomplete fix which set "*.*" as the > policy-value for the default policy. ( > https://issues.apache.org/jira/secure/attachment/12902787/0001-RANGER-1932.patch) > > > Diffs > ----- > > > plugin-yarn/src/main/java/org/apache/ranger/services/yarn/RangerServiceYarn.java > a10c1ca > > > Diff: https://reviews.apache.org/r/64926/diff/1/ > > > Testing > ------- > > Passed all unit tests. > > > Thanks, > > Abhay Kulkarni > >
