----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65119/#review195500 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On Jan. 12, 2018, 6:43 a.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65119/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2018, 6:43 a.m.) > > > Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul > Parikh, suja s, and Velmurugan Periasamy. > > > Bugs: RANGER-1952 > https://issues.apache.org/jira/browse/RANGER-1952 > > > Repository: ranger > > > Description > ------- > > **Problem Statement:** User's email address is not a mandatory field so if a > user wants to change his email address to blank then API should allow that. > > **Proposed Solution:** By Removing blank email check restriction from > UserMgr.changeEmailAddress() method this issue can be fixed. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 5f85066 > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 9614184 > > > Diff: https://reviews.apache.org/r/65119/diff/1/ > > > Testing > ------- > > Steps performed(with patch) : > 1. Installed and started Ranger admin. > 2. Created a user with valid email address. > 3. Tried to set user's email address to blank: > > Sample Request after encoding: curl -u inuser1:user1234 --header > "Accept:application/json" -H "Content-Type:application/json" -X POST > "http://localhost:6080/service/users/20/emailchange"; -d > '{"loginId":"inuser1","emailAddress":""}' > > 4. Visited user tab from user/group menu to see the updated email address. > > > **Expected Behaviour:** User 'inuser1' email should reset to blank. > **Actual Behaviour:** User 'inuser1' email was reset to blank. > > > Thanks, > > Pradeep Agrawal > >
