----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65511/#review196824 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Feb. 5, 2018, 7:01 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65511/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2018, 7:01 p.m.) > > > Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy. > > > Bugs: RANGER-1781 > https://issues.apache.org/jira/browse/RANGER-1781 > > > Repository: ranger > > > Description > ------- > > Hive Masking policy page changes in table and column fields > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java > 608d258 > > agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java > 08f5437 > > > Diff: https://reviews.apache.org/r/65511/diff/1/ > > > Testing > ------- > > Tested with local VM. > > 1. Created a service-def from a JSON file created by copying > ranger-servicedef-hive.json and changing its name to test. Verified that > database record for resource-defs for this service-def shows correct values > of datamask_options and row_filter options. > 2. Updated hive service-def from a JSON file created by copying > ranger-servicedef-hive (needed to delete a few policies, modify tag policy > for update to succeed). Verified that database record for resource-defs for > hive service-def now shows correct values of datamask_options and row_filter > options. > 3. Deleted hive service-def from Ranger (after deleting all its policies and > cl1_hive service). Restarted ranger and verified that hive service-def is > created from embedded service-defs, and its database record shows correct > values of datamask_options and rowfilter_options. > > > Thanks, > > Abhay Kulkarni > >
