-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65871/#review198483
-----------------------------------------------------------




agents-common/src/main/resources/service-defs/ranger-servicedef-atlas.json
Line 15 (original), 48 (patched)
<https://reviews.apache.org/r/65871/#comment278639>

    Mandatory attribute is not needed any more. Removing it will keep 
service-def less cluttered.



agents-common/src/main/resources/service-defs/ranger-servicedef-atlas.json
Lines 59 (patched)
<https://reviews.apache.org/r/65871/#comment278638>

    This attribute will be internally computed based on the resource-hierarchy 
(isValidLeaf=true if the resource is a leaf resource, false otherwise). 
Consider specifying this explicitly only if override is desired. It will keep 
service-def less cluttered.


- Abhay Kulkarni


On March 1, 2018, 9:52 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65871/
> -----------------------------------------------------------
> 
> (Updated March 1, 2018, 9:52 p.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, Nixon 
> Rodrigues, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-2004
>     https://issues.apache.org/jira/browse/RANGER-2004
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Apache Atlas updated the authorization model in ATLAS-2459, to support 
> authroization at instance level. Ranger authorization plugin for Atlas has 
> been updated to support this model.
> (publishing review for the patch from Nixon)
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-atlas.json 
> 4a550c64 
>   plugin-atlas/pom.xml 54917f66 
>   
> plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java
>  90e75a1a 
> 
> 
> Diff: https://reviews.apache.org/r/65871/diff/1/
> 
> 
> Testing
> -------
> 
> Deployed the updated plugin and verified authorization and audit logs for 
> various scenarios (entity-read, entity-add-classification, 
> entity-remove-classification, ..).
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Reply via email to