----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65981/#review198871 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On March 8, 2018, 9:57 a.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65981/ > ----------------------------------------------------------- > > (Updated March 8, 2018, 9:57 a.m.) > > > Review request for ranger, Gautam Borad, Mehul Parikh, Nikhil P, Pradeep > Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-1963 > https://issues.apache.org/jira/browse/RANGER-1963 > > > Repository: ranger > > > Description > ------- > > – Change the icon to show query to be more button-like where the action is > intuitive (similar to buttons on policy list page) > – Provide copy to clipboard function in the popup > – Change the title of popup to be "Hive Query" > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/utils/XAViewUtils.js 28a6b44 > security-admin/src/main/webapp/styles/xa.css d57d169 > > > Diff: https://reviews.apache.org/r/65981/diff/1/ > > > Testing > ------- > > 1.Tested that the button is clickable. > 2.Tested that popup has 'copy to clipboard button'. > 3.Tested that full query is getting copied when we click the 'copy to > clipboard button'. > 4.Tested that the popup title is changed to 'Hive Query'. > > > Thanks, > > Nitin Galave > >
