----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66021/#review199001 -----------------------------------------------------------
Ship it! Ship It! - Mehul Parikh On March 10, 2018, 3:27 p.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66021/ > ----------------------------------------------------------- > > (Updated March 10, 2018, 3:27 p.m.) > > > Review request for ranger, Mehul Parikh, Pradeep Agrawal, and Velmurugan > Periasamy. > > > Bugs: RANGER-2014 > https://issues.apache.org/jira/browse/RANGER-2014 > > > Repository: ranger > > > Description > ------- > > 1.On Policy listing page: Policy view mode popup is not coming after > changing/updating recursive toggle button in the policy form. > 2.Policy, service, user, group create/edit page show horizontal scrollbar. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js > 80ef1f1 > security-admin/src/main/webapp/templates/kms/KmsKeyCreate_tmpl.html b4b7f03 > > security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html > eb844ff > security-admin/src/main/webapp/templates/service/ServiceCreate_tmpl.html > 7464f83 > security-admin/src/main/webapp/templates/users/GroupCreate_tmpl.html > ffc29bf > security-admin/src/main/webapp/templates/users/UserCreate_tmpl.html 13ce8cc > > > Diff: https://reviews.apache.org/r/66021/diff/1/ > > > Testing > ------- > > 1.Able see policy view mode after updating recursive flag. > 2.Verified policy, service, user, group create/edit does not show horizontal > scrollbar. > > > Thanks, > > Nitin Galave > >