----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65920/#review199151 -----------------------------------------------------------
Fix it, then Ship it! tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java Line 208 (original), 209 (patched) <https://reviews.apache.org/r/65920/#comment279460> This would cause NPE, if 'val' is null i.e. when property TAGSYNC_ENABLED_PROP is not set. Consider replacing this with: return val == null || Boolean.valueOf(val.trim()); Same applies for line #214 as well. - Madhan Neethiraj On March 12, 2018, 10:16 a.m., Nikhil P wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65920/ > ----------------------------------------------------------- > > (Updated March 12, 2018, 10:16 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan > Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2010 > https://issues.apache.org/jira/browse/RANGER-2010 > > > Repository: ranger > > > Description > ------- > > Ranger Tagsync should use cookie based authentication for subsequent requests > to Ranger admin. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java > 0d94edc > tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java > 697c7cc > > tagsync/src/main/java/org/apache/ranger/tagsync/sink/tagadmin/TagAdminRESTSink.java > a1dc8f5 > tagsync/src/main/resources/ranger-tagsync-site.xml 3542ae2 > > > Diff: https://reviews.apache.org/r/65920/diff/4/ > > > Testing > ------- > > 1)verified if ranger tagsync works as expected. > 2)verified if tagsync is not re-login for every notification if > "ranger.tagsync.cookie.enabled" is set as true. > > > File Attachments > ---------------- > > 0003-RANGER-2010-Ranger-Tagsync-should-use-cookie-based-a.patch > > https://reviews.apache.org/media/uploaded/files/2018/03/12/3f7133ab-72f9-413e-997c-4d9265f88cdc__0003-RANGER-2010-Ranger-Tagsync-should-use-cookie-based-a.patch > > > Thanks, > > Nikhil P > >
