----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66080/#review199251 -----------------------------------------------------------
Ship it! Ship It! - Mehul Parikh On March 15, 2018, 7:21 a.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66080/ > ----------------------------------------------------------- > > (Updated March 15, 2018, 7:21 a.m.) > > > Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and > Velmurugan Periasamy. > > > Bugs: RANGER-2015 > https://issues.apache.org/jira/browse/RANGER-2015 > > > Repository: ranger > > > Description > ------- > > 1. In view policy we are able to see 'Deny Policy' & 'Except Conditions' even > if 'enableDenyAndExceptionsInPolicies : False' (Deny Policy and Except > Conditions are hidden in policy create/edit screen) > > 2. Improvement in policy view mode popup. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > d10c6a7 > > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyConditions.js > 96d9c8b > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyDetail.js > 80ef1f1 > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js > 998a0a9 > > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js > b4006ce > security-admin/src/main/webapp/styles/xa.css 4ba75fb > > security-admin/src/main/webapp/templates/policies/RangerPolicyConditions_tmpl.html > 6a46bbd > > security-admin/src/main/webapp/templates/policies/RangerPolicyDetail_tmpl.html > fae698d > security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html > 801681b > > > Diff: https://reviews.apache.org/r/66080/diff/2/ > > > Testing > ------- > > 1. Unable to see 'Deny Policy' & 'Except Conditions' when > enableDenyAndExceptionsInPolicies is set to false and vice versa working as > expected. > 2. Also checked newly added policy view mode popup in various places (policy > listing view, Audit->access tab policy view etc.) > > > Thanks, > > Nitin Galave > >
