----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66089/#review199415 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java Line 63 (original), 64 (patched) <https://reviews.apache.org/r/66089/#comment279744> This "Value" annotation is not needed, isn't it? The loginFormUrl is specified in the XML, this value would be used only if the RangerAuthenticationEntryPoint would be initialized by some other auto-magic. Honestly, I would love if everything could be configured without XML, but this is a bit confusing now. - Zsombor Gegesy On March 15, 2018, 1:54 p.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66089/ > ----------------------------------------------------------- > > (Updated March 15, 2018, 1:54 p.m.) > > > Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul > Parikh, suja s, and Velmurugan Periasamy. > > > Bugs: RANGER-2018 > https://issues.apache.org/jira/browse/RANGER-2018 > > > Repository: ranger > > > Description > ------- > > Here I am proposing to change Spring Security to 4.2.4 and Spring Framework > to 4.3.14. > > > Diffs > ----- > > pom.xml 1df5f2c > > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java > d9c2bcf > > security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java > 370df70 > security-admin/src/main/resources/conf.dist/security-applicationContext.xml > 0dda56b > security-admin/src/main/webapp/META-INF/applicationContext.xml de1dc67 > security-admin/src/main/webapp/META-INF/asynctask-applicationContext.xml > 10f1a84 > security-admin/src/main/webapp/META-INF/scheduler-applicationContext.xml > a9fb632 > security-admin/src/main/webapp/scripts/mgrs/SessionMgr.js 529a589 > security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js eb65283 > security-admin/src/main/webapp/scripts/views/common/ProfileBar.js c6301c3 > > security-admin/src/test/java/org/apache/ranger/service/PasswordComparisonAuthenticator.java > 3dc6413 > > > Diff: https://reviews.apache.org/r/66089/diff/1/ > > > Testing > ------- > > Tested the Ranger admin installation, user login, ldap authentication , > usersync and other crud operations on service, policy, user and group module. > > > Thanks, > > Pradeep Agrawal > >
