----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66085/#review199471 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On March 19, 2018, 8:56 a.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66085/ > ----------------------------------------------------------- > > (Updated March 19, 2018, 8:56 a.m.) > > > Review request for ranger, bhavik patel, Gautam Borad, Abhay Kulkarni, Madhan > Neethiraj, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan > Periasamy. > > > Bugs: RANGER-2019 > https://issues.apache.org/jira/browse/RANGER-2019 > > > Repository: ranger > > > Description > ------- > > **Problem Statement:** Based on this RANGER-2004 commit, Atlas service def is > updated. During the upgrade of existing env, old Atlas service def should be > renamed so that new service def can be used. > > **Proposed Solution:** Proposed Java patch can address the atlas service def > rename fix. During migration to latest Ranger, this Java patch should do the > following: > 1. Check for service-def named 'atlas'. If it is not found - nothing more to > do. > 2. Rename all service instances of type 'atlas', with addition of suffix > "-v1". Existing service named 'cl1_atlas' will become 'cl1_atlas-v1'. If > 'cl1_atlas-v1' already exists, append an count like 'cl1_atlas-v1.1', > 'cl1_atlas-v1.2' > 3. After all service instances are renamed, rename service-def as 'atlas-v1'. > > **Note:** In Upgrade case, as the old atlas service def id can't be used to > create the new atlas service def so I am proposing change to update the atlas > servicedef id from 11 to 15. > > > Diffs > ----- > > agents-common/src/main/resources/service-defs/ranger-servicedef-atlas.json > 2891129 > > security-admin/src/main/java/org/apache/ranger/patch/PatchForAtlasServiceDefUpdate_J10013.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66085/diff/2/ > > > Testing > ------- > > Tested for fresh and upgrade case. > > > Thanks, > > Pradeep Agrawal > >
