----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66216/#review199757 -----------------------------------------------------------
Ship it! Ship It! - Ankita Sinha On March 22, 2018, 1:30 p.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66216/ > ----------------------------------------------------------- > > (Updated March 22, 2018, 1:30 p.m.) > > > Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, > Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-2030 > https://issues.apache.org/jira/browse/RANGER-2030 > > > Repository: ranger > > > Description > ------- > > Added policy expired indicator to policy edit and listing page and also some > minor improvements. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/utils/XAUtils.js 9e17951 > security-admin/src/main/webapp/scripts/views/policies/PolicyTimeList.js > 0d88072 > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js > 1b82128 > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js > 6d511e1 > > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js > b849799 > security-admin/src/main/webapp/styles/xa.css ebb6284 > > security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html > e85faa8 > > > Diff: https://reviews.apache.org/r/66216/diff/1/ > > > Testing > ------- > > 1.Policies are getting saved with the different timezone. > 2.Policies are getting saved with multiple timezones. > 3.Policy edit/listing page is getting an expired indication when end time > exceeds current time in the single timezone. > 4.Policy edit/listing is getting an expired indication when end time exceeds > current time in multiple time zones. > > > Thanks, > > Nitin Galave > >
