> On April 2, 2018, 5:40 a.m., Pradeep Agrawal wrote: > > security-admin/src/main/java/org/apache/ranger/patch/PatchGrantAuditPermissionToKeyRoleUser_J10013.java > > Lines 88 (patched) > > <https://reviews.apache.org/r/66279/diff/1/?file=1987381#file1987381line88> > > > > Is it okay to continue the flow if either of them is null
Yes even if any one of the module object is null then it will go as per the flow and if both module's object is null then it will log an a warning and exit. - Fatima ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66279/#review200275 ----------------------------------------------------------- On April 2, 2018, 7:39 a.m., Fatima Khan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66279/ > ----------------------------------------------------------- > > (Updated April 2, 2018, 7:39 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and > Sailaja Polavarapu. > > > Bugs: RANGER-2039 > https://issues.apache.org/jira/browse/RANGER-2039 > > > Repository: ranger > > > Description > ------- > > Currently by default users having Keyadmin or KMS auditor role doesn't get > access to Audits tab in Ranger UI, but ideally it should have audit access > right so that when we login through keyadmin and KMS Auditor we should be > able to view the KMS related audits and user/groups tab. > > > Diffs > ----- > > security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 65fc51c > security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql > 0634776 > security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql > 70f4bcc > > security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql > d59788c > security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql > f67f109 > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java b3d3e96 > > security-admin/src/main/java/org/apache/ranger/patch/PatchGrantAuditPermissionToKeyRoleUser_J10014.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66279/diff/2/ > > > Testing > ------- > > Tested the by creating Auditor and KMS Auditor role user's get default access > to users/groups tab and Audit tab > > > Thanks, > > Fatima Khan > >
